Use the new "durability" infrastructure from salsa #1445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some numbers: previously, what we were doing was basically |
flodiebold
reviewed
Jun 26, 2019
| eprint!("comment change: "); | ||
| { | ||
| let mut text = host.analysis().file_text(file_id).to_string(); | ||
| text.push_str("\n/* Hello world */\n"); |
There was a problem hiding this comment.
a slightly more interesting change might be putting the comment at the top?
There was a problem hiding this comment.
That would be harder to implement, because I would need to adjust offset for subsequent queries.
ideally, we should accept a .patch file as a command line argument...
matklad
force-pushed
the
durability
branch
6 times, most recently
from
61b0c1c to
b3d791d
Compare
matklad
force-pushed
the
durability
branch
7 times, most recently
from
4086608 to
3b312b4
Compare
matklad
force-pushed
the
durability
branch
8 times, most recently
from
a4f06ba to
bdd9b11
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 15, 2019
1445: Use the new "durability" infrastructure from salsa r=matklad a=matklad Based on https://github.com/nikomatsakis/salsa/tree/durability Durability allows us to skip *validation* work for sysroot and crates.io libraries, which massively speeds up some workloads Co-authored-by: Aleksey Kladov <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://github.com/nikomatsakis/salsa/tree/durability
Durability allows us to skip validation work for sysroot and crates.io libraries, which massively speeds up some workloads