feat: Convert nested function to closure assist #14455
Conversation
rustbot
added
the
S-waiting-on-review
jplatte
changed the title
crates/ide-assists/src/handlers/convert_nested_function_to_closure.rs
Outdated
Show resolved
Hide resolved
crates/ide-assists/src/handlers/convert_nested_function_to_closure.rs
Outdated
Show resolved
Hide resolved
crates/ide-assists/src/handlers/convert_nested_function_to_closure.rs
Outdated
Show resolved
Hide resolved
| .ancestors() | ||
| .skip(1) | ||
| .find_map(ast::Item::cast) | ||
| .map_or(false, |it| matches!(it, ast::Item::Fn(_))) |
There was a problem hiding this comment.
| .map_or(false, |it| matches!(it, ast::Item::Fn(_))) | |
| .map_or(false, |it| matches!(it, ast::Item::Fn(_) | ast::Item::Static(_) | ast::Item::Const(_))) |
Might as well make it usable in other bodies
There was a problem hiding this comment.
I reckon it's extremely uncommon to have a function nested inside a const or static initializer, but sure why not 😄
There was a problem hiding this comment.
I'm not going to deny that, but you never know (If we want to be very pedantic, we should actually check for enum variants, const arguments and const parameter defaults as well 😶)
There was a problem hiding this comment.
I understand const arguments and const parameter defaults, but enum variants? You mean enum variant numbers, as in you can have a block expression in enum Foo { Bar = <here> }? 😂
|
@bors r+ |
Veykril
changed the title
|
Thanks, to you too of course @mdx97! |
|
☀️ Test successful - checks-actions |
Continuation of / closes #13467.
Resolves #13230.
r? @Veykril