Skip to content

fix: place type inlay hints after the item and without left-padding #14818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2023
Merged

fix: place type inlay hints after the item and without left-padding #14818

merged 1 commit into from
May 18, 2023

Conversation

poliorcetics
Copy link
Contributor

@poliorcetics poliorcetics commented May 16, 2023 •
edited
Loading

Before:

Type hints were placed before the item and there was left-padding that accentuaded the issue

After:

Type hints are now placed after the item and without padding since there already is : in front of the type

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 16, 2023
@poliorcetics
Copy link
Contributor Author

I think this broke in #14794 sinc yesterday it was working fine

@poliorcetics poliorcetics force-pushed the type-hints-after-item branch from ef87163 to 22599ad Compare May 16, 2023 13:13
Veykril
Veykril approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors is still dead so we can't merge it right now

crates/ide/src/inlay_hints/bind_pat.rs
position: InlayHintPosition::Before,
pad_left: !has_colon,
position: InlayHintPosition::After,
pad_left: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah the pad logic is faulty here in general ... I'll fix that up myself later.

@Veykril
Copy link
Member

Veykril commented May 18, 2023

@bors r+

@bors
Copy link
Contributor

bors commented May 18, 2023

📌 Commit 22599ad has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented May 18, 2023

⌛ Testing commit 22599ad with merge c4026bf...

@Veykril Veykril mentioned this pull request May 18, 2023
Closed
@bors
Copy link
Contributor

bors commented May 18, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing c4026bf to master...

@bors bors merged commit c4026bf into rust-lang:master May 18, 2023
@poliorcetics poliorcetics deleted the type-hints-after-item branch May 18, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veykril Veykril Veykril approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@poliorcetics @Veykril @bors @rustbot