Removes */ from block doc comments
#1630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjeremy
changed the title
*/ in block doc comments*/ from block doc comments
|
An alternate implementation would be to provide a |
matklad
reviewed
Jul 31, 2019
crates/ra_syntax/src/ast/traits.rs
Outdated
| line[pos..].to_owned() | ||
| let end = if comment.kind().shape.is_block() && line.ends_with("*/") { | ||
| // FIXME: Use `nth_back` here once stable | ||
| if line.chars().rev().nth(2).map(|c| c.is_whitespace()).unwrap_or(false) { |
There was a problem hiding this comment.
Let's check that c s is ascii as well, otherwise this will panic on weird uicode whitespace characters.
There was a problem hiding this comment.
Maybe use line[..line.len() - 2].trim_end() below instead.
There was a problem hiding this comment.
I like the trim_end() on every comment line. Is there a reason we can't unconditionally do that?
There was a problem hiding this comment.
I just did that in the latest commit.
|
@matklad is this version good to go? |
|
yep! bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 3, 2019
1630: Removes `*/` from block doc comments r=matklad a=kjeremy The trailing `/` was annoying me on hover. Co-authored-by: kjeremy <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trailing
/was annoying me on hover.