internal: Migrate assists to the structured snippet API, part 6/7 #16467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
Fixes #13558 too, since the structured snippet API always escapes existing backslashes and dollar signs in code. |
DropDemBits
force-pushed
the
structured-snippet-migrate-6
branch
from
26cdb10 to
d6dd9eb
Compare
Veykril
approved these changes
Feb 8, 2024
|
Thanks! |
bors
added a commit
that referenced
this pull request
Feb 8, 2024
…ykril internal: Migrate assists to the structured snippet API, part 6/7 Continuing from #16082 Migrates the following assists: - `extract_function` - `generate_getter_or_setter` - `generate_impl` - `generate_new` - `replace_derive_with_manual_impl` Would've been the final PR in the structured snippet migration series, but I didn't notice that `generate_trait_from_impl` started to use `{insert,replace}_snippet` when I first started the migration 😅. This appears to be a pretty self-contained change, so I'll leave that for a separate future PR. This also removes the last usages of `render_snippet`, which was a follow up goal of #11638. 🎉
|
💔 Test failed - checks-actions |
|
Some clippy lints need fixing (we enabled clippy since) |
|
✌️ @DropDemBits, you can now approve this pull request! If @Veykril told you to " |
|
☔ The latest upstream changes (presumably #16477) made this pull request unmergeable. Please resolve the merge conflicts. |
`make::impl_` no longer merges generic params and args in order to be in line with `make::impl_`, which doesn't do it either.
Shortcut version of `make::expr_path(make::path_unqualified(make::path_segment_self()))`
Needed to recreate the behavior of `generate_new` addding the `new` method at the start of the impl
All usages of `render_snippet` and `Cursor` have been removed as part of the migration
DropDemBits
force-pushed
the
structured-snippet-migrate-6
branch
from
d6dd9eb to
11b075b
Compare
DropDemBits
force-pushed
the
structured-snippet-migrate-6
branch
from
11b075b to
05b8ccc
Compare
|
@bors r+ |
|
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Feb 16, 2024
…ykril internal: Migrate assists to the structured snippet API, part 7/7 Continuing from #16467 Migrates the following assists: - `generate_trait_from_impl` This adds `add_placeholder_snippet_group`, which adds a group of placeholder snippets which are linked together and allows for renaming generated items without going through a separate rename step. This also removes the last usages of `SourceChangeBuilder::{insert,replace}_snippet`, as all assists have finally been migrated to the structured snippet versions of those methods.
This was referenced May 9, 2024
This was referenced May 28, 2024
This was referenced Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from #16082
Migrates the following assists:
extract_functiongenerate_getter_or_settergenerate_implgenerate_newreplace_derive_with_manual_implWould've been the final PR in the structured snippet migration series, but I didn't notice that
generate_trait_from_implstarted to use{insert,replace}_snippetwhen I first started the migration 😅. This appears to be a pretty self-contained change, so I'll leave that for a separate future PR.This also removes the last usages of
render_snippet, which was a follow up goal of #11638. 🎉