fix: Temporarily disable completion resolve support for helix and neovim #18630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
changed the title
Veykril
commented
Dec 6, 2024
| } | ||
|
|
||
| pub fn client_is_neovim(&self) -> bool { | ||
| self.client_info.as_ref().map(|it| it.name == "Neovim").unwrap_or_default() |
There was a problem hiding this comment.
Found this string in one issue in hrsh7th/cmp-nvim-lsp#36, so I'll just hope that that works
SomeoneToIgnore
approved these changes
Dec 6, 2024
| @@ -41,7 +41,11 @@ pub fn server_capabilities(config: &Config) -> ServerCapabilities { | |||
| })), | |||
| hover_provider: Some(HoverProviderCapability::Simple(true)), | |||
| completion_provider: Some(CompletionOptions { | |||
| resolve_provider: Some(config.caps().completions_resolve_provider()), | |||
| resolve_provider: if config.client_is_helix() || config.client_is_neovim() { | |||
| None | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Veykril
force-pushed
the
push-ystzsxpywnxn
branch
from
0b82318 to
ad01392
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #18547 (comment)