feat: Warn the user when a rename will change the meaning of the program #19079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
reviewed
Feb 5, 2025
ChayimFriedman2
force-pushed
the
rename-conflict
branch
from
f87a7b8 to
0c7c63e
Compare
ChayimFriedman2
force-pushed
the
rename-conflict
branch
from
0c7c63e to
bd1abdc
Compare
|
Okay I removed the dummy edit. |
|
I ran into this earlier where a rename caused a compilation error. Not super confusing to deal with, but this would be a cool feature. |
Specifically, when a rename of a local will change some code that refers it to refer another local, or some code that refer another local to refer to it. We do it by introducing a dummy edit with an annotation. I'm not a fond of this approach, but I don't think LSP has a better way.
ChayimFriedman2
force-pushed
the
rename-conflict
branch
from
bd1abdc to
62e7d28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, when a rename of a local will change some code that refers it to refer another local, or some code that refer another local to refer to it.
We do it by introducing a dummy edit with an annotation. I'm not a fond of this approach, but I don't think LSP has a better way.
Demo:
Screen.Recording.2025-02-02.015127.mp4
Closes #10713.