fix: Prevent wrong invocations of needs_parens_in with non-ancestral "parent"s
#19324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ShoyuVanilla
commented
Mar 9, 2025
| check_assist( | ||
| apply_demorgan, | ||
| "fn() { let x = a && !(!b |$0| !c); }", | ||
| "fn() { let x = a && b && c; }", | ||
| "fn() { let x = a && (b && c); }", | ||
| ) |
There was a problem hiding this comment.
These test chages might be a regression, but I think that the changed ones are more consistent with other test cases
ShoyuVanilla
changed the title
need_parens_in with non-ancestral "parent"sneeds_parens_in with non-ancestral "parent"s
ShoyuVanilla
commented
Mar 9, 2025
| }; | ||
| Some((range, name_ref, initializer_expr.needs_parens_in(&usage_parent))) | ||
| let should_wrap = initializer_expr | ||
| .needs_parens_in_place_of(&usage_parent, usage_node.as_ref().unwrap()); |
There was a problem hiding this comment.
let a = 123 < 456;
let b = !a;In the above code, initializer_expr is 123 < 456 and usage_parent is let b = !a. So, inside needs_parens_in, it assumes that initializer_expr "comes before parent" because its text range is earlier, and decides that it needs no parentheses
ShoyuVanilla
force-pushed
the
migrate-inline-var
branch
from
0844786 to
5b202cb
Compare
Veykril
approved these changes
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19323
This also migrates
inline_local_variabletoSyntaxEditoras a part of #18285