fix: Fix a bug in orphan rules calculation #19466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
davidbarsky
approved these changes
Mar 27, 2025
ChayimFriedman2
force-pushed
the
bug-coherence
branch
from
35c2fa3 to
93c30c4
Compare
Where a fundamental type applied twice wasn't considered local.
ChayimFriedman2
force-pushed
the
bug-coherence
branch
from
93c30c4 to
246d678
Compare
👀 I didn't know that, nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where a fundamental type applied twice wasn't considered local.
We're going to get a full coherence checker for free with the next trait solver, so I don't want to invest in completing the current check, but this fix is simple enough and it can cause annoying red squiggles.