ci: cancel parallel jobs if test fails #19521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
BenjaminBrienen
approved these changes
Apr 4, 2025
|
Maybe we should just run it on release, perhaps with |
Trying that out in #19532 |
|
Cancelling everything kind of defeats the point of some checks imo |
|
Yeah, but wouldn't you say that it's mandatory for tests to pass before we bother with the other jobs? There are also some jobs which will always run to completion simply because they're super fast (rustfmt, typos), and will finish before we reach the testing step. |
|
I think that it makes sense. Fail-fast saves CI time, and I think most people fix one thing at a time anyway. |
Kobzol
reviewed
Apr 11, 2025
Signed-off-by: Prajwal S N <[email protected]>
Veykril
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The analysis-stats job takes ~12m to run. This will run even if the tests fail - it's wasted CI minutes. Instead, we can short-circuit the entire workflow if the tests fail.