refactor: Turn LifetimeRef into an enum
#19550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
force-pushed
the
push-rsskztqzwuzk
branch
from
731c244 to
69913aa
Compare
davidbarsky
approved these changes
Apr 9, 2025
crates/hir-def/src/hir/type_ref.rs
Outdated
| pub enum LifetimeRef { | ||
| Named(Name), | ||
| Static, | ||
| Infer, |
There was a problem hiding this comment.
For consistency with Named, I think this should be Inferred?
Suggested change
| Infer, | |
| Inferred |
There was a problem hiding this comment.
Oh, well. I mean, up to you.
There was a problem hiding this comment.
Actually I'll name it Placeholder to mirror TypeRef
This makes things more structured
Veykril
force-pushed
the
push-rsskztqzwuzk
branch
from
69913aa to
0721214
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes things more structured