fix: Fix a small bug with catastrophic effects #19558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tiny bug was that `FnFlags::DEPRECTAED_SAFE_2024` and `FnFlags::RUSTC_ALLOW_INCOHERENT_IMPLS` were assigned the same value. The catastrophic effect was that every function marked as `#[rustc_allow_incoherent_impl]` was considered safe-deprecated for edition 2024, which caused it to be considered unsafe to call when called from edition 2024. And that includes `<[_]>::into_vec()`, which is called by the `vec![]` macro. So, catastrophic effect. This innocent-looking bug probably arose from the item tree rewrite. No review would've catch that!
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
changed the title
|
Whoops, might be good to double check all those flags (and their naming), as i had a couple collisions from your tool attribute PR there |
|
I kicked off another nightly given just how annoying this bug is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tiny bug was that
FnFlags::DEPRECTAED_SAFE_2024andFnFlags::RUSTC_ALLOW_INCOHERENT_IMPLSwere assigned the same value.The catastrophic effect was that every function marked as
#[rustc_allow_incoherent_impl]was considered safe-deprecated for edition 2024, which caused it to be considered unsafe to call when called from edition 2024. And that includes<[_]>::into_vec(), which is called by thevec![]macro. So, catastrophic effect.This innocent-looking bug probably arose from the item tree rewrite. No review would've catch that!
Fixes #19557.