Do not perform PGO on Linux CI #19583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
reviewed
Apr 14, 2025
|
Also I think we should be good to enable it for windows (if things work there) since zigbuild isn't necessary for windows anyways from my understanding |
Kobzol
changed the title
Kobzol
force-pushed
the
revert-19582-ci-pgo
branch
from
cc7c256 to
4c86214
Compare
|
Good point, I only reverted the Linux PGO change, and kept the rest. I'll try to enable it on Windows in a separate PR. |
Veykril
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts a part of #19582. PGO does not seem to work with
cargo zigbuild(https://github.com/rust-lang/rust-analyzer/actions/runs/14448767429/job/40515878851).