Skip to content

doc: Rework generated configuration to have anchors #19638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2025

Conversation

bbb651
Copy link
Contributor

@bbb651 bbb651 commented Apr 20, 2025

Also fixes first line of default code blocks being used as the language instead of json and fixes a missing json language in a doc comment code block.

I manually included the ids to avoid mkBook stripping away the dots, and to remove the rust-analyzer. prefix.

Currently this line is still included as an <h2> which is not ideal but seems tricky to fix properly.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 20, 2025
@bbb651 bbb651 force-pushed the doc-config-anchors branch from 9db213b to c8fc738 Compare April 20, 2025 16:11
Also first line of default code blocks being used as the language instead of json
and fixes a missing `json` language in a doc comment code block.
@bbb651 bbb651 force-pushed the doc-config-anchors branch from c8fc738 to 2ffcb99 Compare April 20, 2025 16:29
@ChayimFriedman2
Copy link
Contributor

Yes please! I wanted this countless times.

Thanks!

@ChayimFriedman2 ChayimFriedman2 added this pull request to the merge queue Apr 20, 2025
@bbb651
Copy link
Contributor Author

bbb651 commented Apr 20, 2025

Fixes #19567, I forgot to add it in the commit message to link it.
I've also made a commit fixing all the dead links, I'll make a follow up PR, and I just discovered the diagnostics in the diagnostics page are missing https://rust-analyzer.github.io/book/diagnostics.html 😅

Merged via the queue into rust-lang:master with commit 794d478 Apr 20, 2025
15 checks passed
@bbb651
Copy link
Contributor Author

bbb651 commented Apr 20, 2025

and I just discovered the diagnostics in the diagnostics page are missing https://rust-analyzer.github.io/book/diagnostics.html 😅

It works after generating the file with cargo xtask, so we either need to do that in CI or not gitignore it like configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants