Skip to content

fix: panics in inlay hints that produce empty text edits for closure return types #19647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

fix: panics in inlay hints that produce empty text edits for closure return types #19647

merged 1 commit into from
Apr 22, 2025

Conversation

roife
Copy link
Member

@roife roife commented Apr 21, 2025 •
edited
Loading

fix #19646.

It's illegal to return TextEdit::builder().finish() here.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 21, 2025
@roife
Copy link
Member Author

roife commented Apr 21, 2025

This issue frequently occurs for me, and it's weird that so few people report it 🫤

@roife roife force-pushed the fix-issue-19646 branch from 09b6cc1 to e73f4ef Compare April 22, 2025 15:59
@roife roife force-pushed the fix-issue-19646 branch from e73f4ef to 97fa2a7 Compare April 22, 2025 16:01
@Veykril Veykril added this pull request to the merge queue Apr 22, 2025
Merged via the queue into rust-lang:master with commit 4e4aee4 Apr 22, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veykril Veykril Veykril approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inlay hint produced an empty text edit
3 participants
@roife @Veykril @rustbot