Always error when failed to parse DiscoverProjectMessage #19684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
davidbarsky
approved these changes
Apr 25, 2025
facebook-github-bot
pushed a commit
to facebook/buck2
that referenced
this pull request
Apr 25, 2025
Summary: Currently if rust-project emits a malformed `DiscoverProjectData`, rust-analyzer will silently ignore it. I want to change this in rust-lang/rust-analyzer#19684, but we need to first ensure that rust-project only emits these events and not other logs. Currently, all tracing events are emitted by the `ProgressLayer`. This diff makes it so only events with an explicit `kind` are emitted. Reviewed By: davidbarsky, dtolnay Differential Revision: D73638698 fbshipit-source-id: 11cc8d95f250ab8fa3d315a2ac69ad01e2f7372d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we silently fail if the line can be parsed as json but not as
DiscoverProjectData. That means if the discover command emits a malformedDiscoverProjectData, project discovery will never finish, and rust-analyzer becomes unusable. Instead, return an error if the line isn't a validDiscoverProjectDataso the discovery process fails and the error is correctly reported.