refactor: Cleanup cfg check handling in expression store lowering #19713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
force-pushed
the
push-xkppskpmuzpo
branch
from
1747e1a to
443ec83
Compare
Veykril
changed the title
|
Oh, one commit got squashed into this, but that only forced threads to be named. |
Veykril
force-pushed
the
push-xkppskpmuzpo
branch
from
443ec83 to
ef44049
Compare
Veykril
force-pushed
the
push-xkppskpmuzpo
branch
from
ef44049 to
d11dbf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was handled fairly inconsistent, which also meant for some parts we wouldn't even show the disabled code diagnostic. This fixes that as well as making things a bit more performant.