Enable the SemanticTokensFeature by default #3899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is covered under vscode's "editor.semanticHighlighting.enabled" setting plus the user has to have a theme that has opted into highlighting. Bumps required vscode stable to 1.44
|
bors r+ 🎉 |
Build succeeded |
|
Note that we could remove |
|
Yup, my thoughts exactly! We also have one bit of proposed api about call
hierarchy (?).were there any updates on that?
…On Wednesday, 8 April 2020, Jeremy Kolb ***@***.***> wrote:
Note that we could remove "enableProposedApi": true at this point but I
think we should leave it since we'll need it later on.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3899 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANB3MZRWYUA6PTHEZVCZFLRLTQFTANCNFSM4MEF65FA>
.
|
|
No the vscode api is stable but LSP is still proposed I think. The
distinction is... a little confusing which is why I updated the comment.
On Wed, Apr 8, 2020, 6:27 PM Aleksey Kladov <[email protected]>
wrote:
… Yup, my thoughts exactly! We also have one bit of proposed api about call
hierarchy (?).were there any updates on that?
On Wednesday, 8 April 2020, Jeremy Kolb ***@***.***> wrote:
> Note that we could remove "enableProposedApi": true at this point but I
> think we should leave it since we'll need it later on.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <
#3899 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AANB3MZRWYUA6PTHEZVCZFLRLTQFTANCNFSM4MEF65FA
>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3899 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBACRHPEIKYQXO7KG2O6QLRLT24BANCNFSM4MEF65FA>
.
|
|
I'm going to reverify this after updating |
|
Woah, you mean we can use semantic highlighting in stable now? Nice!! |
|
Yes with latest vscode stable and a theme (the default ones work) that supports it. |
|
Can I have a link on what a theme needs to havo in order to support this feature? (I have my own theme) Thank you :D |
I wonder if they have like, ... the actual docs for this? |
|
Is semantic highlighting only available on vscode? Or does emacs support it too? |
|
Vscode for sure. I don't know about emacs.
…On Fri, Apr 17, 2020, 10:29 AM Luis Wirth ***@***.***> wrote:
Is semantic highlighting only available on vscode? Or does emacs support
it too?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3899 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBACRARDILUNLAOVIS5UILRNBRWJANCNFSM4MEF65FA>
.
|
|
support is not yet implemented in emacs: emacs-lsp/lsp-mode#1482 |
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Jan 7, 2025
Android: Added support for prctl handling thread names Addresses the first part of rust-lang#3618.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is covered under vscode's "editor.semanticHighlighting.enabled"
setting plus the user has to have a theme that has opted into highlighting.
Bumps required vscode stable to 1.44
Closes #3773