Improve analysis stats legibility #7250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veykril
pushed a commit
to Veykril/rust-analyzer
that referenced
this pull request
Jan 11, 2021
7250: Improve analysis stats legibility r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
lnicola
reviewed
Jan 14, 2021
| eprintln!( | ||
| "Expressions of unknown type: {} ({}%)", | ||
| " exprs: {}, ??ty: {} ({}%), ?ty: {} ({}%), !ty: {}", |
There was a problem hiding this comment.
I'm not convinced that this is actually more legible 😄.
bors bot
added a commit
that referenced
this pull request
Feb 26, 2022
11560: internal: Update `url` to make `webrender` build when computing metrics r=jonas-schievink a=lnicola Closes #9997 This doesn't seem to affect the metrics, but I'm not sure since somehow I get different values than what shows up on CI. With `stable`: ``` exprs: 94151, ??ty: 96 (0%), ?ty: 25 (0%), !ty: 6 ``` CI shows 16. Also, #7250 strikes again, I can never tell what those numbers are. r? `@jonas-schievink` Co-authored-by: Laurențiu Nicola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bors r+
🤖