Skip to content

feat: Distinguishing between different operators in semantic highlighting #8354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2021

Conversation

chetankhilosiya
Copy link
Contributor

No description provided.

@matklad
Copy link
Member

matklad commented Apr 13, 2021

LGTM! I wish we could say operator.logical, etc, but that isn't supported by the protocol.

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 13, 2021

@bors bors bot merged commit 03e0bf7 into rust-lang:master Apr 13, 2021
@lnicola lnicola changed the title Distinguishing between different operators in semantic highlighting feat: Distinguishing between different operators in semantic highlighting Apr 18, 2021
HlOperator::Bitwise => "bitwise",
HlOperator::Arithmetic => "arithmetic",
HlOperator::Logical => "logical",
HlOperator::Comparision => "comparision",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo here "ision" on both sides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants