Use v2 cargo resolver #2999
Merged
Use v2 cargo resolver #2999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems there are some warnings to fix :) |
nyurik
force-pushed
the
wk-resolver
branch
2 times, most recently
from
88cf7ac to
3d9c3a9
Compare
emilio
reviewed
Nov 29, 2024
bindgen/lib.rs
Outdated
| @@ -74,6 +74,8 @@ use std::path::{Path, PathBuf}; | |||
| use std::process::{Command, Stdio}; | |||
| use std::rc::Rc; | |||
| use std::str::FromStr; | |||
|
|
|||
| #[cfg(feature = "runtime")] | |||
There was a problem hiding this comment.
Maybe move the use std::sync::{Arc, OnceLock}; inside the function?
There was a problem hiding this comment.
yeah, makes sense, fixed
The 2021 usually implies resolver v2, and warns otherwise.
emilio
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2021 usually implies resolver v2, and warns otherwise.