Skip to content

Incorrect use of "either" in section 2.1 #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikong opened this issue Feb 19, 2019 · 1 comment
Closed

Incorrect use of "either" in section 2.1 #1155

mikong opened this issue Feb 19, 2019 · 1 comment

Comments

@mikong
Copy link
Contributor

mikong commented Feb 19, 2019

The second paragraph of section 2.1 reads:

(original)

Integers can, alternatively, be expressed using hexadecimal, octal or binary notation using either of these prefixes: 0x, 0o or 0b.

The use of "either" seems inappropriate given the 3 options. "any" is typically used for 3 options but I wouldn't replace "either" with "any" in this case since you can't just use any of the prefixes if you need a specific notation. It seems better to just remove "either of" and then add "respectively":

(revision 1)

Integers can, alternatively, be expressed using hexadecimal, octal or binary notation using these prefixes respectively: 0x, 0o or 0b.

I would like to move "alternatively" to the start as well, although this is just a matter of preference:

(revision 2)

Alternatively, integers can be expressed using hexadecimal, octal or binary notation using these prefixes respectively: 0x, 0o or 0b.

I can make a pull request if people agree with these changes.

@jonmccune
Copy link

I'm a random Rust n00b going through rust-by-example, and also noticed this incorrect use of "either". Both of your suggestions seem like improvements to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants