Skip to content

Remove cargo dev ra_setup #6883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Y-Nak opened this issue Mar 11, 2021 · 5 comments · Fixed by #6888
Closed

Remove cargo dev ra_setup #6883

Y-Nak opened this issue Mar 11, 2021 · 5 comments · Fixed by #6888
Assignees
@matthiaskrgr
Labels
A-documentation Area: Adding or improving documentation S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work

Comments

@Y-Nak
Copy link
Contributor

Y-Nak commented Mar 11, 2021

#6869 obsoleted cargo dev ra_setup, so we can remove it now!
Also, we need to update Getting code-completion for rustc internals to work to reflect the changes.
@Y-Nak

This comment has been minimized.

Sign in to view
@rustbot rustbot added A-documentation Area: Adding or improving documentation C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages labels Mar 11, 2021
@Y-Nak

This comment has been minimized.

Sign in to view
@rustbot rustbot removed the C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages label Mar 11, 2021
@matthiaskrgr
Copy link
Member

I have been holding off on doing that because I think the rust-analyzer version that provides the feature is not in nightly yet.

@matthiaskrgr
Copy link
Member

The current nightlly ra-version is d54e115 / 2021-03-08.
The support for #6869 has been merged in d57c9f7 which landed afterwards.

The next RA sync will probably be filed around the 15th so perhaps it's save to remove it on 17th-20th when the sync has landed inside the rustc repo.

@matthiaskrgr matthiaskrgr self-assigned this Mar 11, 2021
@matthiaskrgr matthiaskrgr added the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work label Mar 11, 2021
matthiaskrgr added a commit to matthiaskrgr/rust-clippy that referenced this issue Mar 12, 2021
@matthiaskrgr
clippy dev: remove ra_setup
51d5950 
Fixes rust-lang#6883
@matthiaskrgr matthiaskrgr mentioned this issue Mar 12, 2021
Merged
@matthiaskrgr
Copy link
Member

Apparently cargo dev ra-setup is still important for people using intellij-rust so we can't just remove that!

@bors bors closed this as completed in a2ee849 Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthiaskrgr matthiaskrgr

Labels
A-documentation Area: Adding or improving documentation S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: update RA setup documentation matthiaskrgr/rust-clippy
3 participants
@matthiaskrgr @Y-Nak @rustbot