Skip to content

Lint missing lints in LintPasses #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
llogiq opened this issue Apr 3, 2016 · 3 comments
Closed

Lint missing lints in LintPasses #831

llogiq opened this issue Apr 3, 2016 · 3 comments
Labels
C-bug Category: Clippy is not doing the correct thing E-medium Call for participation: Medium difficulty level problem and requires some initial experience. T-middle Type: Probably requires verifiying types

Comments

@llogiq
Copy link
Contributor

llogiq commented Apr 3, 2016

If we miss a Lint in the lint_array! of the *LintPass, we will get strange and confusing behavior (like lint warnings + unknown_lint).

This requires walking the call graph and recording any lint symbol on the way. Then checking the get_lints method if all recorded lints are present.

Note that this would be the first lint that is specifically aimed at helping write lints.

@Manishearth Manishearth added C-bug Category: Clippy is not doing the correct thing E-medium Call for participation: Medium difficulty level problem and requires some initial experience. T-middle Type: Probably requires verifiying types labels Apr 3, 2016
@oli-obk
Copy link
Contributor

oli-obk commented Apr 3, 2016

Make sure to take a Totem with you.

@llogiq
Copy link
Contributor Author

llogiq commented Apr 3, 2016

We don't need to follow the call graph, just identify the reachable functions for any LintPass implementation. The naive set-based algorithm should work nicely.

@mcarton
Copy link
Member

mcarton commented Sep 1, 2016

Closed by #1207.

@mcarton mcarton closed this as completed Sep 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Clippy is not doing the correct thing E-medium Call for participation: Medium difficulty level problem and requires some initial experience. T-middle Type: Probably requires verifiying types
Projects
None yet
Development

No branches or pull requests

4 participants