Lint Lints without LintPass

[kennytm]

Added a lint_without_lint_pass lint.

Four lints were missing from LintPass, making them unavailable unless the clippy lint group is explicitly enabled:

• for_loop_over_result
• for_loop_over_option
• match_overlapping_arm
• filter_next

[mcarton]

Thanks!
Travis is not happy because you need to run ./util/update_lints.py.

[mcarton]

Why? 😄

[kennytm]

Oops, forgot to remove it 😛

[mcarton]

• You should move the lint to rust-clippy/clippy_lints/src/utils/internal_lints.rs.

[mcarton]

That's weird. The error is in the JSON:

{"message":"the lint MISSING_LINT is not added to any LintPass","code":null,"level":"error","spans":[{"file_name":"<rustc macros>","byte_start":6188,"byte_end":6293,"line_start":5,"line_end":6,"column_start":1,"column_end":30,"is_primary":true,"text":[{"text":"static $ name : & 'static :: rustc :: lint :: Lint = & lint_initializer ! (","highlight_start":1,"highlight_end":76},{"text":"$ name , $ level , $ desc ) ; ) ;","highlight_start":1,"highlight_end":30}],"label":null,"suggested_replacement":null,"expansion":{"span":{"file_name":"tests/compile-fail/lint_pass.rs","byte_start":234,"byte_end":286,"line_start":13,"line_end":13,"column_start":1,"column_end":53,"is_primary":false,"text":[{"text":"declare_lint! { MISSING_LINT, Warn, \"missing lint\" }","highlight_start":1,"highlight_end":53}],"label":null,"suggested_replacement":null,"expansion":null},"macro_decl_name":"declare_lint!","def_site_span":{"file_name":"<rustc macros>","byte_start":5954,"byte_end":6297,"line_start":1,"line_end":6,"column_start":1,"column_end":34,"is_primary":false,"text":[{"text":"( pub $ name : ident , $ level : ident , $ desc : expr ) => (","highlight_start":1,"highlight_end":62},{"text":"pub static $ name : & 'static :: rustc :: lint :: Lint = & lint_initializer !","highlight_start":1,"highlight_end":78},{"text":"( $ name , $ level , $ desc ) ; ) ; (","highlight_start":1,"highlight_end":38},{"text":"$ name : ident , $ level : ident , $ desc : expr ) => (","highlight_start":1,"highlight_end":56},{"text":"static $ name : & 'static :: rustc :: lint :: Lint = & lint_initializer ! (","highlight_start":1,"highlight_end":76},{"text":"$ name , $ level , $ desc ) ; ) ;","highlight_start":1,"highlight_end":34}],"label":null,"suggested_replacement":null,"expansion":null}}}],"children":[{"message":"lint level defined here","code":null,"level":"note","spans":[{"file_name":"tests/compile-fail/lint_pass.rs","byte_start":75,"byte_end":97,"line_start":5,"line_end":5,"column_start":9,"column_end":31,"is_primary":true,"text":[{"text":"#![deny(lint_without_lint_pass)]","highlight_start":9,"highlight_end":31}],"label":null,"suggested_replacement":null,"expansion":null}],"children":[],"rendered":null},{"message":"for further information visit https://github.com/Manishearth/rust-clippy/wiki#lint_without_lint_pass","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":null}

but does not seem to be seen by compiletest-rs:

actual errors (from JSON output): [
    Error {
        line_num: 5,
        kind: Some(
            Note
        ),
        msg: "5:9: 5:31: lint level defined here"
    }
]

expected errors (from test file): [
    Error {
        line_num: 5,
        kind: Some(
            Note
        ),
        msg: ""
    },
    Error {
        line_num: 13,
        kind: Some(
            Error
        ),
        msg: "the lint MISSING_LINT is not added to any LintPass</del>"
    }
]

[mcarton]

Ah no… I see, the JSON has "file_name":"<rustc macros>" as the span. compiletest-rs thinks that's an error in a different file and just ignores it. See if you can get another span for that.

[mcarton]

*/!\ SPOILER ALERT /!*

diff --git a/clippy_lints/src/lint_pass.rs b/clippy_lints/src/lint_pass.rs
index e041ee4..6840420 100644
--- a/clippy_lints/src/lint_pass.rs
+++ b/clippy_lints/src/lint_pass.rs
@@ -66,12 +66,13 @@ impl LateLintPass for Pass {
     }

     fn check_crate_post(&mut self, cx: &LateContext, _: &Crate) {
-        for (lint_name, lint_span) in &self.declared_lints {
+        for (lint_name, &lint_span) in &self.declared_lints {
+            let lint_span = cx.sess().codemap().source_callsite(lint_span);
             if !self.registered_lints.contains(lint_name) {
                 span_lint(cx,
                           LINT_WITHOUT_LINT_PASS,
-                          *lint_span,
-                          &format!("the lint {} is not added to any LintPass", lint_name));
+                          lint_span,
+                          &format!("the lint `{}` is not added to any `LintPass`", lint_name));
             }
         }
     }

[llogiq]

Whoa! Didn't see that one coming!

[kennytm]

@mcarton Thanks! Add changes amended.

[mcarton]

Thanks!