validate lint name in clippy_dev
#10817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @dswij (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
flip1995
reviewed
May 24, 2023
clippy_dev/src/main.rs
Outdated
| .required(true) | ||
| .value_parser(|name: &str| { | ||
| if name.contains('-') { | ||
| Err("Lint name cannot contain `-`, use `_` instead.") |
There was a problem hiding this comment.
Instead of error, would it make sense to just replace - with _? I don't think there ever is a use case where you want -.
There was a problem hiding this comment.
That makes sense to me (assuming that was directed at me). I think it's safe to assume that the user probably didn't want the literal character - but just meant to have it as a delimiter and replacing it with _ is fine
There was a problem hiding this comment.
Yes, that question was for you :)
flip1995
approved these changes
May 24, 2023
flip1995
reviewed
May 24, 2023
Co-authored-by: Philipp Krones <[email protected]>
|
@bors r+ Thanks! |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a little bit of validation to
cargo dev new_lint. I've had it happen a few times where I wanted to add a new lint, but forgot that lint names cannot contain-. If you try to do it anyway,clippy_devwill generate illegal syntax (like addingmod test-lint;to clippy_lints/src/lib.rs for the module declaration). Maybe having it error out early would be helpful to others too.changelog: none