[missing_const_for_fn]: Ensure dropped locals are ~const Destruct
#10891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Alexendoo (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
I have no experience on the MIR side of things, r? @Jarcho who I think does |
Jarcho
reviewed
Jun 7, 2023
Jarcho
reviewed
Jun 8, 2023
|
Ok, I got it working... Sorry for wasting your time with the trait solver shebacle 😅 |
Centri3
commented
Jun 8, 2023
Centri3
force-pushed
the
missing_const_for_fn
branch
from
3fa7739 to
a495fa0
Compare
Jarcho
reviewed
Jun 10, 2023
Jarcho
reviewed
Jun 13, 2023
Centri3
force-pushed
the
missing_const_for_fn
branch
from
34883b2 to
9bc5a14
Compare
|
Thank you. @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will check every local for
TerminatorKind::Dropto ensure they can be evaluated at compile time, not sure if this is the best way to do this but MIR is confusing and it works so...fixes #10617
changelog: [
missing_const_for_fn]: Ensure dropped locals are~const Destruct