[unnecessary_to_owned]: check that the adjusted type matches target
#10913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
r? @Centri3 before I review this as well |
This comment was marked as outdated.
This comment was marked as outdated.
Manishearth
approved these changes
Jun 9, 2023
|
@bors r=Manishearth,Centri3 thanks! |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10033.
Before this change, the lint would assume that removing the
.to_string()inf(&x.to_string())would be ok if x is of some type that implementsDeref<Target = str>andftakes a&str.This turns out to not actually be ok if the
to_stringcall is some method that exists onxdirectly, which happens if it implementsDisplay/ToStringitself.changelog: [
unnecessary_to_owned]: only lint if the adjusted receiver type actually matches