-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[manual_filter_map
]: lint on matches
and pattern matching
#10949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @Alexendoo (rustbot has picked a reviewer for you, use r? to override) |
Alexendoo
reviewed
Jun 14, 2023
Alexendoo
reviewed
Jun 15, 2023
Alexendoo
reviewed
Jun 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, forgot to bless the tests |
Alexendoo
approved these changes
Jul 19, 2023
Thanks, looks good! @bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8010
Previously this lint only worked specifically for a very limited set of methods on the filter call (
.filter(|opt| opt.is_some())
and.filter(|res| res.is_ok())
). This PR extends it to also recognizematches!
in thefilter
and pattern matching withif let
ormatch
in themap
.Example:
Now suggests:
Adding this required a somewhat large change in code because it originally seemed to be specifically written with only method calls in the filter in mind, and
matches!
has different behavior in the map, so this new setup should make it possible to support more "generic" cases that need different handling for the filter and map calls.changelog: [
manual_filter_map
]: lint onmatches
and pattern matching (and some internal refactoring)