Skip to content

check that the types are equal in SpanlessEq::eq_expr #11214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2023

Conversation

y21
Copy link
Member

@y21 y21 commented Jul 23, 2023

Fixes #11213

changelog: [if_same_then_else]: don't lint for integer literals of different types

@rustbot
Copy link
Collaborator

rustbot commented Jul 23, 2023

r? @Jarcho

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 23, 2023
@Jarcho
Copy link
Contributor

Jarcho commented Jul 23, 2023

Thank you. @bors r+

@bors
Copy link
Contributor

bors commented Jul 23, 2023

📌 Commit e975d05 has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 23, 2023

⌛ Testing commit e975d05 with merge 5877504...

@bors
Copy link
Contributor

bors commented Jul 23, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing 5877504 to master...

@bors bors merged commit 5877504 into rust-lang:master Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong if_same_then_else lint error when having two different integer
4 participants