Skip to content

[type_id_on_box]: lint on any Box<dyn _> #11350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 30, 2024
Merged

Conversation

y21
Copy link
Member

@y21 y21 commented Aug 18, 2023

Closes #11349.

It now not only lints when calling .type_id() on the type Box<dyn Any>, but also on any Box<dyn Trait> where Trait is a subtrait of Any

changelog: FN: [type_id_on_box]: lint if Any is a sub trait

@rustbot
Copy link
Collaborator

rustbot commented Aug 18, 2023

r? @giraffate

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 18, 2023
@bors
Copy link
Contributor

bors commented Nov 2, 2023

☔ The latest upstream changes (presumably #11747) made this pull request unmergeable. Please resolve the merge conflicts.

@xFrednet
Copy link
Member

Let's see if we can revive this PR. @y21 would you mind rebasing on master?

r? @xFrednet

@rustbot rustbot assigned xFrednet and unassigned giraffate Mar 29, 2024
@y21 y21 force-pushed the issue11349 branch 2 times, most recently from bbceca2 to a362b2c Compare March 29, 2024 12:43
@y21
Copy link
Member Author

y21 commented Mar 29, 2024

👍

This was surprisingly easy to rebase considering how old this PR is :D just had to re-bless (and format)

Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good to me. I have one small comment and then it should be good to go :)

@y21 y21 changed the title [type_id_on_box]: lint on Any subtraits [type_id_on_box]: lint on any Box<dyn _> Mar 30, 2024
@xFrednet
Copy link
Member

This version looks good to me, thank you for also updating the lint description. I like these changes. It looks like the suggestion good some support on Zulip, if something comes up, we can just create a followup.

Thank you!

@bors r+

@bors
Copy link
Contributor

bors commented Mar 30, 2024

📌 Commit f6c0063 has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 30, 2024

⌛ Testing commit f6c0063 with merge 3787a0c...

@y21
Copy link
Member Author

y21 commented Mar 30, 2024

It looks like the suggestion good some support on Zulip, if something comes up, we can just create a followup.

I cant quite parse this sentence, can you rephrase that ? "Could have some support"?

@bors
Copy link
Contributor

bors commented Mar 30, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 3787a0c to master...

@bors bors merged commit 3787a0c into rust-lang:master Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

type_id_on_box for supertraits of Any
5 participants