-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[type_id_on_box
]: lint on any Box<dyn _>
#11350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @giraffate (rustbot has picked a reviewer for you, use r? to override) |
☔ The latest upstream changes (presumably #11747) made this pull request unmergeable. Please resolve the merge conflicts. |
bbceca2
to
a362b2c
Compare
👍 This was surprisingly easy to rebase considering how old this PR is :D just had to re-bless (and format) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks good to me. I have one small comment and then it should be good to go :)
type_id_on_box
]: lint on Any
subtraitstype_id_on_box
]: lint on any Box<dyn _>
This version looks good to me, thank you for also updating the lint description. I like these changes. It looks like the suggestion good some support on Zulip, if something comes up, we can just create a followup. Thank you! @bors r+ |
I cant quite parse this sentence, can you rephrase that ? "Could have some support"? |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Closes #11349.
It now not only lints when calling
.type_id()
on the typeBox<dyn Any>
, but also on anyBox<dyn Trait>
whereTrait
is a subtrait ofAny
changelog: FN: [
type_id_on_box
]: lint ifAny
is a sub trait