Skip to content

Improve maybe misused cfg #11840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Nov 18, 2023

Follow-up of the improvements that were suggested to me in #11821:

  • I unified the output to use the same terms.
  • I updated the code to prevent creating a new symbol.

r? @blyxyas

changelog: [maybe_misued_cfg]: Output and code improvements

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 18, 2023
@GuillaumeGomez
Copy link
Member Author

Applied the suggestion, thanks @Centri3 !

@blyxyas
Copy link
Member

blyxyas commented Nov 19, 2023

Could you squash these commits into one?

Small performance improvement when comparing symbols for `maybe_misused_cfg`
Improve suggestion for `maybe_misused_cfg` lint
@GuillaumeGomez GuillaumeGomez force-pushed the improve-maybe_misused_cfg branch from 348b4ba to dfbca7f Compare November 19, 2023 21:46
@GuillaumeGomez
Copy link
Member Author

Sure, done!

Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

@blyxyas
Copy link
Member

blyxyas commented Nov 19, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Nov 19, 2023

📌 Commit dfbca7f has been approved by blyxyas

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 19, 2023

⌛ Testing commit dfbca7f with merge 41140e3...

@bors
Copy link
Contributor

bors commented Nov 19, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing 41140e3 to master...

@bors bors merged commit 41140e3 into rust-lang:master Nov 19, 2023
@GuillaumeGomez GuillaumeGomez deleted the improve-maybe_misused_cfg branch November 19, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants