Improve wording for suggestion messages

[GuillaumeGomez]

Follow-up of #12140.

r? @llogiq

changelog: Improve wording for suggestion messages

[GuillaumeGomez]

Fixed CI.

[smoelius]

Please forgive me for chiming in. I was planning to submit a PR to remove all the uses of "consider".

Here is a concrete example:

rust-clippy/clippy_lints/src/copy_iterator.rs

Line 54 in 4b3a9c0

"consider implementing `IntoIterator` instead",

IMHO, "consider" doesn't add anything here, and just the following would suffice:

"implement `IntoIterator` instead", 

EDIT: Do you not agree? Do you think "consider" adds something?

[GuillaumeGomez]

It's possible that the clippy suggestion is either wrong or not the best in a given context. Using "consider" leaves this possibility open and tells the users "it might be better than what you already have, so maybe consider using it?". At least that's how I see it.

[smoelius]

It's possible that the clippy suggestion is either wrong or not the best in a given context. Using "consider" leaves this possibility open ...

OK. (Sorry for jumping on your PR.)

[GuillaumeGomez]

It's fine don't worry. Better discuss before changes are merged to ensure everyone is on board. :)

[llogiq]

Looks good to me. Thank you!

@bors r+

[bors]

📌 Commit 998ba82 has been approved by llogiq

It is now in the queue for this repository.

[bors]

⌛ Testing commit 998ba82 with merge bf2a738...

[bors]

💔 Test failed - checks-action_test

[GuillaumeGomez]

I ran the tests locally and it all worked. Not sure what happened... I rebased just in case.

[y21]

something's up with the macos runners, they have been randomly failing in a bunch of PRs for a few days now
https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/Sporadic.20macos.20failures

so it probably just needs a retry

[llogiq]

@bors retry

[y21]

Hmm seems like that wasn't picked up by bors? Maybe it needs to be reapproved since a new commit was added/history was changed because of the rebase? 🤔

[llogiq]

Let's try that then.

@bors r+

[bors]

📌 Commit 38d9585 has been approved by llogiq

It is now in the queue for this repository.

[bors]

⌛ Testing commit 38d9585 with merge 99423e8...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 99423e8 to master...