Skip to content

chore: starting to fix unnecessary_iter_cloned #13848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

scottgerring
Copy link
Contributor

@scottgerring scottgerring commented Dec 17, 2024

This will address #13099 for the unnecessary_iter_cloned test.

changelog: [unnecessary_iter_cloned]: unnecessary_iter_cloned manual_assert to use multipart_suggestions where appropriate

@rustbot
Copy link
Collaborator

rustbot commented Dec 17, 2024

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 17, 2024
@scottgerring scottgerring force-pushed the chore/fix-unnecessary_iter_cloned branch from 7714e67 to f9e3a47 Compare December 17, 2024 17:11
@scottgerring scottgerring force-pushed the chore/fix-unnecessary_iter_cloned branch from f9e3a47 to 8fe39b2 Compare December 17, 2024 17:14
@scottgerring scottgerring marked this pull request as ready for review December 17, 2024 17:25
@scottgerring
Copy link
Contributor Author

scottgerring commented Dec 17, 2024

@blyxyas now it's ready 😆 Rather straightforward this one!

Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

@blyxyas blyxyas added this pull request to the merge queue Dec 17, 2024
Merged via the queue into rust-lang:master with commit 9f4941a Dec 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants