configuration option to lint incompatible_msrv in test code
#14279
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @blyxyas (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
the
S-waiting-on-review
bryceberger
force-pushed
the
bryce/push-lnpmzsnstrzx
branch
3 times, most recently
from
cb0c689 to
6aebfc1
Compare
There was a problem hiding this comment.
Could you add some tests? We test with different clippy.tomls at tests/ui-toml. You can add a new incompatible-msrv directory if it doesn't exist already, With a check-incompatible-msrv-in-tests = true in that tests/ui-toml/incompatible-msrv/clippy.toml and the following test flag for ui-toml/../<test filename>:
//@compile-flags --test
You can check the files in tests/ui-toml to gather some inspiration :)
bryceberger
force-pushed
the
bryce/push-lnpmzsnstrzx
branch
from
6aebfc1 to
325bfef
Compare
| //@compile-flags: --test | ||
| //@revisions: default enabled | ||
| //@[enabled] rustc-env:CLIPPY_CONF_DIR=tests/ui-toml/check_incompatible_msrv_in_tests/enabled | ||
| //@[default] rustc-env:CLIPPY_CONF_DIR=tests/ui-toml/check_incompatible_msrv_in_tests/default |
There was a problem hiding this comment.
Really smart to use several revisions instead of multiple subdirectories!
fixes #14277
changelog: [
incompatible_msrv]: add config option [check-incompatible-msrv-in-tests] to enable in#[test]and#[cfg(test)]code.