fix: filter_map_bool_then suggest wrongly when the closure cannot be decompose directly
#14370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
profetia
force-pushed
the
issue14368
branch
3 times, most recently
from
1701177 to
cd11752
Compare
profetia
changed the title
filter_map_bool_then suggest wrongly when contain returnfilter_map_bool_then suggest wrongly when the closure cannot be decompose directly
blyxyas
requested changes
Mar 20, 2025
blyxyas
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11617
Closes #14368
Clippy gives wrong suggestions when the filter and then cannot be put into closure directly. Since trying to transform these can be too complicated, Clippy will simply warn but don't try to fix.
changelog: [
filter_map_bool_then]: fix wrong suggestions when the closure cannot be decompose directly