Do not warn about shadowing in a destructuring assigment #14381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
Related: #10279. |
Yes, this will be fixed as well. |
samueltardieu
force-pushed
the
push-vzyluwmvvtys
branch
from
607fb4f to
cd8f848
Compare
|
Out of curiosity, does this fix also work for struct literal destructuring? (I'd also be fine with merging this as is even if not, as this already fixes a bunch of FPs) struct S { a: i32, b: i32 }
let a; let b;
S { a, b } = S { a: 1, b: 2 }; |
samueltardieu
force-pushed
the
push-vzyluwmvvtys
branch
from
cd8f848 to
7d1c452
Compare
It didn't, because I only checked for |
When lowering a destructuring assignment from AST to HIR, the compiler will reuse the same identifier name (namely `sym::lhs`) for all the fields. The desugaring must be checked for to avoid a false positive of the `shadow_unrelated` lint.
samueltardieu
force-pushed
the
push-vzyluwmvvtys
branch
from
7d1c452 to
d9913dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When lowering a destructuring assignment from AST to HIR, the compiler will reuse the same identifier name (namely
sym::lhs) for all the fields. The desugaring must be checked for to avoid a false positive of theshadow_unrelatedlint.Fix #10279
Fix #14377
changelog: [
shadow_unrelated]: prevent false positive in destructuring assignments