Consecutive returns dont decrease cognitive Complexity level anymore

[cerdelen]

changelog: [cognitive_complexity]: Consecutive return calls decreased complexity level of the function by 1.

fixes #14422

[rustbot]

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[y21]

Do you have an example code snippet of some real code that exercises this exception here or motivation on why this change helps? It's a bit hard for me to think about when there would be two return expressions after one another

[cerdelen]

i added the id of the issue apparently it wasnt linked before

It is because you put the initial pull-request message into a code block (surrounded by three backticks). I've edited the code block markers out in the initial message, and this has now linked the issue.

[y21]

I see, thanks for referencing the issue, that gives some context. LGTM, can you add a test for this in tests/ui/cognitive_complexity.rs? (Can just copy it from the linked issue)

[KonaeAkira]

I may be mistaken here, but the bug was a false negative, and the added test tests that the lint is not triggered. Shouldn't the test added in this PR test that the lint is triggered instead?

In other words, the new test would still pass if the bugfix was reverted, which defeats the purpose of the test.

[cerdelen]

You are right. I made another pull request.

#14603