Skip to content

Enable GitHub review synchronization with S-waiting-on-* labels #14567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

samueltardieu
Copy link
Contributor

changelog: none

r? @flip1995

Straight from triagebot's documentation, this should allow the bot to
set and remove the `S-waiting-on-author` and `S-waiting-on-review`
labels when a PR author requests a review, or when a review is done with
changes requested.
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 8, 2025
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Didn't know how powerful triagebot is.

@flip1995 flip1995 added this pull request to the merge queue Apr 9, 2025
Merged via the queue into rust-lang:master with commit e0e2a93 Apr 9, 2025
11 checks passed
@samueltardieu samueltardieu deleted the push-nmtszpmyllkt branch April 9, 2025 16:23
@samueltardieu
Copy link
Contributor Author

samueltardieu commented Apr 9, 2025

That worked, I've experimented with it while reviewing #13710 and requesting changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants