Linter to check that all common metadata is included #3419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
reviewed
Nov 8, 2018
flip1995
approved these changes
Nov 8, 2018
|
I'm not sure what's up with the test failure. In TravisCI I'm seeing this: Yet, when I run that locally with the latest nightly, it's a-ok: |
|
Ah, I see. It's made some changes that I need to commit. |
oli-obk
reviewed
Nov 13, 2018
clippy_lints/Cargo.toml
Outdated
| @@ -17,7 +17,7 @@ keywords = ["clippy", "lint", "plugin"] | |||
| edition = "2018" | |||
|
|
|||
| [dependencies] | |||
| cargo_metadata = "0.6" | |||
| cargo_metadata = { git = "https://github.com/ysimonson/cargo_metadata", branch = "include-all-common-metadata" } | |||
ysimonson
force-pushed
the
include-all-common-metadata
branch
from
2df2d04 to
866caab
Compare
|
bors r+ Thanks! |
bors bot
added a commit
that referenced
this pull request
Nov 15, 2018
3419: Linter to check that all common metadata is included r=flip1995 a=ysimonson Addresses #1793 This is not ready to be merged yet. First the associated changes to `cargo_metadata` need to be merged: oli-obk/cargo_metadata#55 Co-authored-by: Yusuf Simonson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1793
This is not ready to be merged yet. First the associated changes to
cargo_metadataneed to be merged: oli-obk/cargo_metadata#55