Update why transmute_int_to_float is bad #3783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ Thanks! |
|
📌 Commit 74ac35b has been approved by |
bors
added a commit
that referenced
this pull request
Feb 18, 2019
Update why transmute_int_to_float is bad As suggested in #3550, this PR changes the reason why using `transmute` from an integer to a float is not recommended. Effectively, `from_bits` uses `transmute` underneath, but the former is preferred.
|
@bors retry |
|
I think retry doesn't work if there's a commit in between. (What's up with Travis / RTIM today?) @bors r=Manishearth |
|
📌 Commit 8994466 has been approved by |
bors
added a commit
that referenced
this pull request
Feb 18, 2019
Update why transmute_int_to_float is bad As suggested in #3550, this PR changes the reason why using `transmute` from an integer to a float is not recommended. Effectively, `from_bits` uses `transmute` underneath, but the former is preferred.
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #3550, this PR changes the reason why using
transmutefrom an integer to a float is not recommended. Effectively,from_bitsusestransmuteunderneath, but the former is preferred.