Skip to content

Fix false negative of checked_conversion lint #5677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2020
Merged

Fix false negative of checked_conversion lint #5677

merged 1 commit into from
Jun 3, 2020

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Jun 2, 2020

Closes #5675
changelog: none

@rust-highfive
Copy link

r? @matthiaskrgr

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 2, 2020
@tesuji tesuji force-pushed the checked_conv branch 3 times, most recently from 2e32362 to dffe58f Compare June 2, 2020 14:40
@tesuji tesuji requested a review from matthiaskrgr June 3, 2020 07:03
@matthiaskrgr
Copy link
Member

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Jun 3, 2020

📌 Commit b39fd5f has been approved by matthiaskrgr

@bors
Copy link
Contributor

bors commented Jun 3, 2020

⌛ Testing commit b39fd5f with merge e2fdeec...

@matthiaskrgr
Copy link
Member

Ah crap, for next time, changelog line should be something like
"Changelog: Fix false negative of checked_conversion lint " 😅

@bors
Copy link
Contributor

bors commented Jun 3, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: matthiaskrgr
Pushing e2fdeec to master...

@bors bors merged commit e2fdeec into rust-lang:master Jun 3, 2020
@tesuji tesuji deleted the checked_conv branch June 3, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiaskrgr matthiaskrgr Awaiting requested review from matthiaskrgr

Assignees

@matthiaskrgr matthiaskrgr

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False negative checked_conversions for Int::MAX
4 participants
@tesuji @rust-highfive @matthiaskrgr @bors