-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add MSRV to more lints specified in #6097 #6424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
r? @flip1995 |
LGTM. There are some extra blank lines added (mostly before the Do you want to add the rest of the lints in this PR or split this up? |
@flip1995 think I'll add all the lints in this one along with some instructions for introducing |
Great! Please ping me, when you're done, so I don't miss it |
@flip1995 could you please review these changes? |
4e3ec90
to
01894ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but something is going on with manual_strip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you squash some of the commits, please? There are 3 or 4 formatting commits.
Just did! Are we good to merge this? |
Thanks! I think we can start writing up the internals blog post 👍 @bors r+ |
📌 Commit 9f27b74 has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
add MSRV to more lints specified in #6097
add instructions for adding msrv in other lints
update tests
redundant_field_names
requires Rust 1.17 due to suggest feature stablized in that version.redundant_static_lifetimes
requires Rust 1.17 due to suggest feature stablized in that version.filter_map_next
requires Rust 1.30 due to suggestIterator::find_map
.checked_conversions
requires Rust 1.34 due to suggestTryFrom
.match_like_matches_macro
requires Rust 1.42 due to suggestmatches!
. Addressed in Add support for minimum supported rust version #6201manual_strip
requires Rust 1.45 due to suggeststr::{strip_prefix, strip_suffix}
. Addressed in Add support for minimum supported rust version #6201option_as_ref_deref
requires Rust 1.40 due to suggestOption::{as_deref, as_deref_mut}
. Addressed in Add support for minimum supported rust version #6201manual_non_exhaustive
requires Rust 1.40 due to suggest#[non_exhaustive]
. Addressed in Add support for minimum supported rust version #6201manual_range_contains
requires Rust 1.35 due to suggestRange*::contains
.use_self
requires Rust 1.37 due to suggestSelf::Variant on enum
.mem_replace_with_default
requires Rust 1.40 due to suggestmem::take
.map_unwrap_or
requires Rust 1.41 due to suggestResult::{map_or, map_or_else}
.missing_const_for_fn
requires Rust 1.46 due tomatch/if/loop in const fn
needs that version.changelog: Add MSRV config to more lints. ^This is now the complete list, AFAWK