New internal lint: Interning defined symbol #6448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
ghost
changed the title
ghost
commented
Dec 13, 2020
| then { | ||
| // SAFETY: We're converting the raw bytes of the symbol value back | ||
| // into a Symbol instance. | ||
| let symbol = unsafe { std::mem::transmute::<u32, Symbol>(value) }; |
There was a problem hiding this comment.
I'm doubting if this is actually safe. This might be wrong if the compiler uses a different version of rustc_span and symbols were added or removed.
|
I thought of a way of doing this without unsafe code. I'll update later. @rustbot modify labels: +S-waiting-on-author |
rustbot
added
the
S-waiting-on-author
|
@rustbot modify labels: -S-waiting-on-author |
rustbot
removed
the
S-waiting-on-author
|
@bors r+ great idea! |
|
📌 Commit f732cc5 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New internal lint: interning_defined_symbol
changelog: none