Added cargo dev setup git-hook and updated cargo dev setup intellij including a remove command

[xFrednet]

This PR enables our dev tool to install a git hook that formats the code before each commit and also runs update_lints to make sure that everything is registered correctly. The script is located at util/etc/pre-commit.sh. I found it reasonable to locate it in the util folder and decided to add a etc in correlation to the main rust repo and to bring a bit of structure into it.

• The hook can be installed via: cargo dev setup git-hook
• And removed via: cargo dev remove git-hook

cc: #5394

The refactoring of src/ide_setup.rs to src/setup/intellij.rs is an extra commit to simplify the review.

---

Changes:

• Added cargo dev setup git-hook for formatting before every commit
• Added cargo dev remove git-hook to remove the hook again
• Added cargo dev remove intellij to remove rustc source path dependencies
• Changed cargo dev ide_setup to cargo dev setup intellij

changelog: none

This is only an internal change and therefore not worth an entry in the general change log.

---

Tested on:

• Linux (by @xFrednet)
• Windows (All used commands run inside the git bash, so it's very likely to work as well @xFrednet)
• macOS

[rust-highfive]

r? @giraffate

(rust-highfive has picked a reviewer for you, use r? to override)

[flip1995]

How much work would it be to add a cargo dev remove intellij?

[xFrednet]

Well, not much I believe, but I haven't looked into it, as I don't use IntelliJ. I also plan to add cargo dev setup vscode-tasks and the removal of it. I can take a look at the IntelliJ removal as well if you like. 🙃 (It would make sense to add that)

[flip1995]

That would be great! If you find that it would be too much work for this PR, let me know and I'll review it in the current state.

[xFrednet]

Converted to draft until I've reviewed the work required to undo the IntelliJ setup command. The current version should still be fully working.

[xFrednet]

I've looked into adding the cargo dev remove intellij command. It looks pretty simple, however I noticed that the current implementation also seems to be a bit broken:

• It doesn't add the new source paths to the clippy_util/Cargo.toml
• It also adds clippy_util as a dependency in clippy_lints/Cargo.toml

  clippy_utils = { path = "/home/xfrednet/workspace/rust/rust/compiler/clippy_utils" }
  

I want to fix them as well, I guess that this will be about 150 additional changes.

[xFrednet]

I'm not done yet, this commit only cleans up some message and makes the setup more expandable. The rest of the work should still be reasonably straight forward. 🙃

[xFrednet]

Okay, I've updated the dev tool to also include a remove command for intellij and give some nicer error messages when calling the setup command.

# Inject dependencies
cargo dev setup intellij
# Remove dependencies again
cargo dev remove intellij

I was debating if it should be renamed to something like cargo dev setup rustc-sources --repo-path ... and cargo dev remove rustc-sources but that also sounded a bit weird. I'm open to suggestions, or we leave it as it is 🙃. I'll try to test the git-hook on Windows soon, but I don't have access to a mac to test the hook on there as well.

[flip1995]

Code LGTM now. I'll give those commands a try locally and then this should be good to merge.

[flip1995]

Rebased and good to merge. Thanks, great work!

@bors r+

[bors]

📌 Commit 8e969cd has been approved by flip1995

[bors]

⌛ Testing commit 8e969cd with merge a03dfb9...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing a03dfb9 to master...

[xFrednet]

You're welcome! I plan to also add a setup to add vs-code tasks to compile and test Clippy. Could you check the git-hook suggestion in the linked ticket as that has been implemented in this PR #5394.

Was there a reason for the rebase? 😅 (just interested :))

[flip1995]

I had to rebase locally anyway (since this branch still used the old nightly), so I figured, why not push it. I don't think this was necessary though.

I checked it off in #5394

[xFrednet]

Ahh makes sense. Thank you :)