Skip to content

Rustup to 1.9.0-nightly (30a3849f2 2016-03-30) #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "clippy"
version = "0.0.58"
version = "0.0.59"
authors = [
"Manish Goregaokar <[email protected]>",
"Andre Bogus <[email protected]>",
Expand Down
7 changes: 4 additions & 3 deletions src/array_indexing.rs
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
use rustc::lint::*;
use rustc::middle::const_eval::EvalHint::ExprTypeChecked;
use rustc::middle::const_eval::{eval_const_expr_partial, ConstVal};
use rustc::middle::const_val::ConstVal;
use rustc::ty::TyArray;
use rustc_const_eval::EvalHint::ExprTypeChecked;
use rustc_const_eval::eval_const_expr_partial;
use rustc_const_math::ConstInt;
use rustc_front::hir::*;
use rustc_const_eval::ConstInt;
use syntax::ast::RangeLimits;
use utils;

Expand Down
3 changes: 1 addition & 2 deletions src/bit_mask.rs
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
use rustc::lint::*;
use rustc::middle::const_eval::lookup_const_by_id;
use rustc::middle::def::{Def, PathResolution};
use rustc_const_eval::lookup_const_by_id;
use rustc_front::hir::*;
use rustc_front::util::is_comparison_binop;
use syntax::ast::LitKind;
use syntax::codemap::Span;

use utils::span_lint;

/// **What it does:** This lint checks for incompatible bit masks in comparisons.
Expand Down
4 changes: 2 additions & 2 deletions src/consts.rs
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
#![allow(cast_possible_truncation)]

use rustc::lint::LateContext;
use rustc::middle::const_eval::lookup_const_by_id;
use rustc::middle::def::{Def, PathResolution};
use rustc_const_eval::lookup_const_by_id;
use rustc_const_math::{ConstInt, ConstUsize, ConstIsize};
use rustc_front::hir::*;
use rustc_const_eval::{ConstInt, ConstUsize, ConstIsize};
use std::cmp::Ordering::{self, Equal};
use std::cmp::PartialOrd;
use std::hash::{Hash, Hasher};
Expand Down
5 changes: 3 additions & 2 deletions src/enum_clike.rs
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
//! lint on C-like enums that are `repr(isize/usize)` and have values that don't fit into an `i32`

use rustc::lint::*;
use syntax::attr::*;
use rustc::middle::const_val::ConstVal;
use rustc_const_math::*;
use rustc_front::hir::*;
use rustc::middle::const_eval::{ConstVal, EvalHint, eval_const_expr_partial};
use syntax::attr::*;
use utils::span_lint;

/// **What it does:** Lints on C-like enums that are `repr(isize/usize)` and have values that don't fit into an `i32`.
Expand Down
2 changes: 1 addition & 1 deletion src/identity_op.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use rustc::lint::*;
use rustc_front::hir::*;
use syntax::codemap::Span;
use utils::{span_lint, snippet, in_macro};
use rustc_const_eval::ConstInt;
use rustc_const_math::ConstInt;

/// **What it does:** This lint checks for identity operations, e.g. `x + 0`.
///
Expand Down
1 change: 1 addition & 0 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ extern crate quine_mc_cluskey;

extern crate rustc_plugin;
extern crate rustc_const_eval;
extern crate rustc_const_math;
use rustc_plugin::Registry;

pub mod consts;
Expand Down
5 changes: 3 additions & 2 deletions src/loops.rs
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
use reexport::*;
use rustc::front::map::Node::NodeBlock;
use rustc::lint::*;
use rustc::middle::const_eval::EvalHint::ExprTypeChecked;
use rustc::middle::const_eval::{ConstVal, eval_const_expr_partial};
use rustc::middle::const_val::ConstVal;
use rustc::middle::def::Def;
use rustc::middle::region::CodeExtent;
use rustc::ty;
use rustc_const_eval::EvalHint::ExprTypeChecked;
use rustc_const_eval::eval_const_expr_partial;
use rustc_front::hir::*;
use rustc_front::intravisit::{Visitor, walk_expr, walk_block, walk_decl};
use std::borrow::Cow;
Expand Down
7 changes: 4 additions & 3 deletions src/matches.rs
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
use rustc::lint::*;
use rustc::middle::const_eval::EvalHint::ExprTypeChecked;
use rustc::middle::const_eval::{eval_const_expr_partial, ConstVal};
use rustc::middle::const_val::ConstVal;
use rustc::ty;
use rustc_const_eval::EvalHint::ExprTypeChecked;
use rustc_const_eval::eval_const_expr_partial;
use rustc_const_math::ConstInt;
use rustc_front::hir::*;
use rustc_const_eval::ConstInt;
use std::cmp::Ordering;
use syntax::ast::LitKind;
use syntax::codemap::Span;
Expand Down
5 changes: 3 additions & 2 deletions src/methods.rs
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
use rustc::lint::*;
use rustc::middle::const_eval::EvalHint::ExprTypeChecked;
use rustc::middle::const_eval::{ConstVal, eval_const_expr_partial};
use rustc::middle::const_val::ConstVal;
use rustc::middle::cstore::CrateStore;
use rustc::ty::subst::{Subst, TypeSpace};
use rustc::ty;
use rustc_const_eval::EvalHint::ExprTypeChecked;
use rustc_const_eval::eval_const_expr_partial;
use rustc_front::hir::*;
use std::borrow::Cow;
use std::fmt;
Expand Down
8 changes: 4 additions & 4 deletions src/misc.rs
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
use reexport::*;
use rustc::lint::*;
use rustc::middle::const_eval::ConstVal::Float;
use rustc::middle::const_eval::EvalHint::ExprTypeChecked;
use rustc::middle::const_eval::eval_const_expr_partial;
use rustc::middle::const_val::ConstVal;
use rustc::ty;
use rustc_const_eval::EvalHint::ExprTypeChecked;
use rustc_const_eval::eval_const_expr_partial;
use rustc_front::hir::*;
use rustc_front::intravisit::FnKind;
use rustc_front::util::{is_comparison_binop, binop_to_string};
Expand Down Expand Up @@ -180,7 +180,7 @@ impl LateLintPass for FloatCmp {

fn is_allowed(cx: &LateContext, expr: &Expr) -> bool {
let res = eval_const_expr_partial(cx.tcx, expr, ExprTypeChecked, None);
if let Ok(Float(val)) = res {
if let Ok(ConstVal::Float(val)) = res {
val == 0.0 || val == ::std::f64::INFINITY || val == ::std::f64::NEG_INFINITY
} else {
false
Expand Down
5 changes: 3 additions & 2 deletions src/regex.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
use regex_syntax;
use rustc::lint::*;
use rustc::middle::const_eval::EvalHint::ExprTypeChecked;
use rustc::middle::const_eval::{eval_const_expr_partial, ConstVal};
use rustc::middle::const_val::ConstVal;
use rustc_const_eval::EvalHint::ExprTypeChecked;
use rustc_const_eval::eval_const_expr_partial;
use rustc_front::hir::*;
use std::collections::HashSet;
use std::error::Error;
Expand Down
11 changes: 6 additions & 5 deletions src/types.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use reexport::*;
use rustc::lint::*;
use rustc::middle::{const_eval, def};
use rustc::middle::def;
use rustc::ty;
use rustc_front::hir::*;
use rustc_front::intravisit::{FnKind, Visitor, walk_ty};
Expand Down Expand Up @@ -683,10 +683,11 @@ fn detect_absurd_comparison<'a>(cx: &LateContext, op: BinOp_, lhs: &'a Expr, rhs
}

fn detect_extreme_expr<'a>(cx: &LateContext, expr: &'a Expr) -> Option<ExtremeExpr<'a>> {
use rustc::middle::const_eval::EvalHint::ExprTypeChecked;
use types::ExtremeType::*;
use rustc::middle::const_eval::ConstVal::*;
use rustc::middle::const_val::ConstVal::*;
use rustc_const_math::*;
use rustc_const_eval::EvalHint::ExprTypeChecked;
use rustc_const_eval::*;
use types::ExtremeType::*;

let ty = &cx.tcx.expr_ty(expr).sty;

Expand All @@ -695,7 +696,7 @@ fn detect_extreme_expr<'a>(cx: &LateContext, expr: &'a Expr) -> Option<ExtremeEx
_ => return None,
};

let cv = match const_eval::eval_const_expr_partial(cx.tcx, expr, ExprTypeChecked, None) {
let cv = match eval_const_expr_partial(cx.tcx, expr, ExprTypeChecked, None) {
Ok(val) => val,
Err(_) => return None,
};
Expand Down
17 changes: 7 additions & 10 deletions tests/consts.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,19 @@
#![feature(rustc_private)]

extern crate clippy;
extern crate syntax;
extern crate rustc;
extern crate rustc_front;
extern crate rustc_const_eval;
extern crate rustc_const_math;
extern crate rustc_front;
extern crate syntax;

use clippy::consts::{constant_simple, Constant, FloatWidth};
use rustc_const_math::ConstInt;
use rustc_front::hir::*;
use rustc_const_eval::ConstInt;
use syntax::ast::{LitIntType, LitKind, StrStyle};
use syntax::codemap::{Spanned, COMMAND_LINE_SP};
use syntax::parse::token::InternedString;
use syntax::ptr::P;
use syntax::codemap::{Spanned, COMMAND_LINE_SP};

use syntax::ast::LitKind;
use syntax::ast::LitIntType;
use syntax::ast::StrStyle;

use clippy::consts::{constant_simple, Constant, FloatWidth};

fn spanned<T>(t: T) -> Spanned<T> {
Spanned{ node: t, span: COMMAND_LINE_SP }
Expand Down