Skip to content

fix wording for derivable_impls #9425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2022
Merged

fix wording for derivable_impls #9425

merged 1 commit into from
Sep 4, 2022

Conversation

kraktus
Copy link
Contributor

@kraktus kraktus commented Sep 4, 2022

While looking at the explanation as to why this lint was not automatically applicable, found the explanation a bit clunky grammatically.

Feel free to close if you consider the wording was correct in the first place.

changelog: none

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @xFrednet (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 4, 2022
@xFrednet
Copy link
Member

xFrednet commented Sep 4, 2022

Welcome 👋

LGTM, you need to run cargo dev update_lints to update some documentation files in Clippy. Afterwards we can merge it :)

@kraktus
Copy link
Contributor Author

kraktus commented Sep 4, 2022

done thanks for the quick review

@xFrednet
Copy link
Member

xFrednet commented Sep 4, 2022

Looks good to me, thank you for the update 🙃

@bors r+

@bors
Copy link
Contributor

bors commented Sep 4, 2022

📌 Commit 2cc20e3 has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 4, 2022

⌛ Testing commit 2cc20e3 with merge 90804d3...

@bors
Copy link
Contributor

bors commented Sep 4, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 90804d3 to master...

@bors bors merged commit 90804d3 into rust-lang:master Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants