This repository was archived by the owner on Apr 5, 2024. It is now read-only.
Pinning a nightly toolchain version #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work with cargo-bisect-rust, that's helpful! I hope you don't mind me pinning the version first, I wanted to clean up the current state a little bit first. Could you rebase and skip the CI changes from here? It'd be great if we could get the ball rolling and start incrementally getting sermverver up to speed in terms of latest nightly support. Thank you! |
|
@Xanewok Done |
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This repo currently doesn't work on latest nightly, and it's hard to keep up with each nightly, so what tools like miri and others do is pin a specific nightly version and bump it as often as they like, that way you batch fixes and don't need to run around fixing it every day.
using bisect-rustc(https://github.com/rust-lang/cargo-bisect-rustc) with
rustc-devenabled(rust-lang/cargo-bisect-rustc#101) I was able to find the latest nightly we can still compile against, from that I looked for the latest one that contains dev tools like clippy, rustfmt, etc. and that's how I got tonightly-2020-06-10:Bisect output
EDIT: I fixed the tests, changed the CI so it will use the pinned version, and modified the README to reflect the changes.
feel free to comment / ask for changes :)