Added support for rustfmt before save

[grncdr]

I really enjoyed this feature from vim-go
so I copied it for rust & rustfmt.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[steveklabnik]

This isn't a "real" license, so I wonder if we can take it...

[steveklabnik]

General 👍 on this idea, for sure.

[grncdr]

I'm happy to update the license, was just a bit lazy when putting this together. The vim-go plugin I was working off of is BSD licensed, this repo has no license, and I guess rust itself is licensed under the Apache & MIT licenses? Would appreciate a recommendation as to the correct license to satisfy all of the above.

A more annoying (for me anyways 😉) problem: the vim-go plugin works by writing the buffer contents to a temporary file, then calling gofmt on that. This doesn't work for rust crates with multiple files, because rustfmt will fail when it can't find other modules in the crate. I'm working out a solution, but for now I'd slap a big "WIP" label on this.

[steveklabnik]

All Rust stuff is MIT/ Apache2, we forgot to add the license locally when we moved it out of the main repo

Sent from my iPhone

On Oct 3, 2015, at 12:53, Stephen Sugden [email protected] wrote:

I'm happy to update the license, was just a bit lazy when putting this together. The vim-go plugin I was working off of is BSD licensed, this repo has no license, and I guess rust itself is licensed under the Apache & MIT licenses? Would appreciate a recommendation as to the correct license to satisfy all of the above.

A more annoying (for me anyways ) problem: the vim-go plugin works by writing the buffer contents to a temporary file, then calling gofmt on that. This doesn't work for rust crates with multiple files, because rustfmt will fail when it can't find other modules in the crate. I'm working out a solution, but for now I'd slap a big "WIP" label on this.

―
Reply to this email directly or view it on GitHub.

[grncdr]

Given that there isn't a license on anything else, I've simply removed that line.

[IanConnolly]

Was doing this myself!

@grncdr Could you add a :RustFmt command that calls the function? No reason why the user couldn't define it themselves, but I feel like rust.vim has the right to do it for them :P

@steveklabnik What's outstanding for @grncdr to do to get this merged? Happy to help.

[steveklabnik]

I'm horrible at vimscript, so I'm not sure. Let's say that yeah, we need that :RustFmt command and then let's get this merged. I like the idea of the command so that other stuff can build on top of it, and it seems consistent with the rest of the bindings.

[IanConnolly]

@grncdr I know the vim-go function adds errors to the quickfix list, but do you think the location list might be a better option? That way you can keep the errors for multiple windows in their respective location lists. Syntastic adds errors to the loclist for this reason.

EDIT: Sidenote as they're not linked, this'll fix #43.

[oblitum]

So, I guess this feature has been merged in #52, but this pull was left dangling?

[mbyio]

Yeah, it looks that way to me.