-
Notifications
You must be signed in to change notification settings - Fork 305
Integrate with rustfmt #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2389eb7
Added support for rustfmt before save
grncdr b68da6e
Fix rustfmt for multi-file crates
grncdr 65549fb
Remove silly license from rustfmt.vim
grncdr 0981f9e
Add new RustFmt command and fix bugs
IanConnolly 89e5a08
Properly populate loclist
IanConnolly 8e90d4f
Don't echo errors we can't parse
IanConnolly cf7a668
Documentation written
IanConnolly 08fbc67
Point out help file
IanConnolly 15081c8
Fix README typo
IanConnolly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,79 @@ | ||
" Author: Stephen Sugden <[email protected]> | ||
" | ||
" Adapted from https://github.com/fatih/vim-go | ||
|
||
if !exists("g:rustfmt_autosave") | ||
let g:rustfmt_autosave = 0 | ||
endif | ||
|
||
if !exists("g:rustfmt_command") | ||
let g:rustfmt_command = "rustfmt" | ||
endif | ||
|
||
if !exists("g:rustfmt_options") | ||
let g:rustfmt_options = "" | ||
endif | ||
|
||
if !exists("g:rustfmt_fail_silently") | ||
let g:rustfmt_fail_silently = 0 | ||
endif | ||
|
||
let s:got_fmt_error = 0 | ||
|
||
function! rustfmt#Format() | ||
let l:curw = winsaveview() | ||
let l:tmpname = expand("%:p:h") . "/." . expand("%:p:t") . ".rustfmt" | ||
call writefile(getline(1, '$'), l:tmpname) | ||
|
||
let command = g:rustfmt_command . " --write-mode=overwrite " | ||
|
||
let out = systemlist(command . g:rustfmt_options . " " . shellescape(l:tmpname)) | ||
|
||
if v:shell_error == 0 | ||
" remove undo point caused via BufWritePre | ||
try | silent undojoin | catch | endtry | ||
|
||
" Replace current file with temp file, then reload buffer | ||
call rename(l:tmpname, expand('%')) | ||
silent edit! | ||
let &syntax = &syntax | ||
|
||
" only clear location list if it was previously filled to prevent | ||
" clobbering other additions | ||
if s:got_fmt_error | ||
let s:got_fmt_error = 0 | ||
call setloclist(0, []) | ||
lwindow | ||
endif | ||
elseif g:rustfmt_fail_silently == 0 | ||
" otherwise get the errors and put them in the location list | ||
let errors = [] | ||
|
||
for line in out | ||
" src/lib.rs:13:5: 13:10 error: expected `,`, or `}`, found `value` | ||
let tokens = matchlist(line, '^\(.\{-}\):\(\d\+\):\(\d\+\):\s*\(\d\+:\d\+\s*\)\?\s*error: \(.*\)') | ||
if !empty(tokens) | ||
call add(errors, {"filename": @%, | ||
\"lnum": tokens[2], | ||
\"col": tokens[3], | ||
\"text": tokens[5]}) | ||
endif | ||
endfor | ||
|
||
if empty(errors) | ||
% | " Couldn't detect rustfmt error format, output errors | ||
endif | ||
|
||
if !empty(errors) | ||
call setloclist(0, errors, 'r') | ||
echohl Error | echomsg "rustfmt returned error" | echohl None | ||
endif | ||
|
||
let s:got_fmt_error = 1 | ||
lwindow | ||
" We didn't use the temp file, so clean up | ||
call delete(l:tmpname) | ||
endif | ||
|
||
call winrestview(l:curw) | ||
endfunction |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
augroup rustfmt | ||
autocmd! | ||
|
||
" code formatting on save | ||
if get(g:, "rustfmt_autosave", 0) | ||
autocmd BufWritePre *.rs call rustfmt#Format() | ||
endif | ||
augroup END |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. I'm trying this out, and it works great!
Just a quick note: here you have
rust_fmt_autosave
as the bool to check for autosave, but the lookup usesg:rustfmt_autosave
(note the extra underscore).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Missed that :) Will fix this evening.